[Buildroot] [PATCH 2/8] package/glmark2: gl support also depends on X.org

Gustavo Zacarias gustavo.zacarias at free-electrons.com
Wed Apr 27 19:38:38 UTC 2016


On 27/04/16 16:32, Thomas Petazzoni wrote:

> I know that may sound like a nitpicking debate, but I'm wondering if we
> shouldn't keep BR2_PACKAGE_MESA3D_OPENGL_GL as an internal mesa3d
> symbol, and instead use:
>
> 	depends on BR2_PACKAGE_HAS_LIBGL && BR2_PACKAGE_MESA3D
>
> which really expresses what we want: we want an OpenGL implementation,
> and this OpenGL implementation has to be mesa3d.
>
> Thomas

I'm fine with nitpicking, however we already use
BR2_PACKAGE_MESA3D_OPENGL_EGL and BR2_PACKAGE_MESA3D_OPENGL_ES in 
glmark2 and weston, which could also ostensibly be replaced by the more 
verbose conditional.
Granted, for weston what it really wants is wayland-egl, which AFAIK 
with our current packages is only provided by mesa3d.
Also while nitpicking the xorg drivers only want DRI so we can keep that 
as is since the xorg conditional is in there already (packages in x11r7/ 
already depend on xorg, plus mesa3d_dri gives opengl). Kind of a maybe 
take back my ACKs for the drivers.
Regards.



More information about the buildroot mailing list