[Buildroot] [PATCH 2/3] c-icap: bump to version 0.4.2
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Tue Apr 19 19:16:02 UTC 2016
Hello,
On Tue, 19 Apr 2016 21:15:45 +0300, Baruch Siach wrote:
> +C_ICAP_CONF_ENV = ac_cv_10031b_ipc_sem=yes ac_cv_fcntl=yes
These look a bit special/weird, especially ac_cv_fcntl=yes. Normally
for functions, the cache variable is named ac_cv_func_<function>, and
the checks don't need to pre-seed cache variable values.
Can you add a comment on top of this line that explains why those two
values need to be passed? Or at least, it should be explained in the
commit log (but a comment in the code is better IMO).
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list