[Buildroot] [PATCHv4] core/pkg-generic: check proper package installation

[Thomas Petazzoni]

Hello,

On Sun, 29 Nov 2015 19:10:07 +0100, Yann E. MORIN wrote:

> Well, I for one would prefer we fail right on the culprit package,
> rather than port-pone the check until the end. This way, it is obvious
> which package is the cuplrit.

It's a matter of trade-off between the benefits and the additional
complexity. IMO, the benefits of failing immediately on the culprit
package are not that big. When we'll look at the incorrectly installed
files, it will in 99% of the cases be obvious from which packages the
files are coming, and in the 1% remaining cases, a simple "find" on a
file with a name that isn't too generic will give us the answer.

> Except we now have a file-> package mapping (thanks to your graph-size),
> so we could re-use that in a target-inalise hook, indeed.
> 
> Well, except maybe not... Can target-finalise be called before we have
> all the host packages (most notably the filesystem image generators)?

The dependencies of rootfs generators are added to PACKAGES, so they
are built before target-finalize:

in fs/common.mk:

PACKAGES += $$(filter-out rootfs-%,$$(ROOTFS_$(2)_DEPENDENCIES))

in Makefile:

target-finalize: $(PACKAGES)

> > Or alternatively, use the existing instrumentation hooks.
> 
> Arnout did not like that, hence why I put in the common install rule.

What was Arnout reasoning?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com