[Buildroot] [PATCH v3 02/13] package/dhcp: systemd: rename environment file

[Benoît Thébaudeau]

Thomas, Gabe, Maxime, all,

On 04/11/2015 11:18, Thomas Petazzoni wrote:
> On Wed, 4 Nov 2015 10:52:10 +0100, Maxime Hadjinlian wrote:
> 
>>> diff --git a/package/dhcp/dhcpd.service b/package/dhcp/dhcpd.service
>>> index 7b265cb..5989506 100644
>>> --- a/package/dhcp/dhcpd.service
>>> +++ b/package/dhcp/dhcpd.service
>>> @@ -7,7 +7,7 @@ Type=forking
>>>  PIDFile=/run/dhcpd.pid
>>>  ExecStart=/usr/sbin/dhcpd -q -pf /run/dhcpd.pid $INTERFACES
>>>  KillSignal=SIGINT
>>> -EnvironmentFile=/etc/default/dhcpd.conf
>>> +EnvironmentFile=/etc/default/dhcpd
>>>
>> Maybe this should be:
>> EnvironmentFile-=/etc/default/dhcpd
> 
> On the dropbear package, Gabe Evans said it may not be such a good idea
> to do this EnvironmentFile thing.

Why? What was the rationale? What would be the alternatives?

> Can we settle on a common decision ?
> 
> (From my PoV, using this EnvironmentFile looked good as it would be a
> common mechanism between the systemd and Busybox/sysvinit cases to tune
> the configuration of services. But Gabe seemed to disagree.)
> 
> Could systemd people in Buildroot decide what to do ? :-)

Benoît