[Buildroot] [PATCH 1/1] system: make sh symlink match original busybox symlink path

[Yann E. MORIN]

Matthew, All,

On 2015-06-16 10:41 -0500, Matthew Starr spake thusly:
> The symlink created by buildroot for /bin/sh when busybox is used
> is the full path to /bin/busybox and does not match the symlink
> created by busybox for /bin/sh, which is just busybox.  When handling
> files on the host system this will point to the host system's busybox
> if present and not the target busybox.

I fail to see the problem that would cause. We have quite a few other
absolute symlinks. Do we want to fix all of them?

Note: yes, I thinf I know what your problenm is, that is checksuming-or-such
the content of each file. I believe this is wrong, because that would
miss the information that this is actually a *symlink*, and would not
detect the fact that is is replacec with an actual file (and hence takes
more place on the device than is expected).

I would find it much smarter that:
  - files get their content checksumed
  - symlinks get their target path checksumed, not the content of the
    target file (or dir). I.e. symlinks should not be dereferenced.

> This is fixed by changing the /bin/sh symlink to just be busybox since
> both files are in the same directory.
> 
> Signed-off-by: Matthew Starr <mstarr at hedonline.com>
> ---
>  system/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/system/Config.in b/system/Config.in
> index 84cde94..5c4ba90 100644
> --- a/system/Config.in
> +++ b/system/Config.in
> @@ -236,7 +236,7 @@ endchoice # /bin/sh
>  
>  config BR2_SYSTEM_BIN_SH
>  	string
> -	default "/bin/busybox" if BR2_SYSTEM_BIN_SH_BUSYBOX
> +	default "busybox" if BR2_SYSTEM_BIN_SH_BUSYBOX

Please, keep the alignment of the if-clause.

>  	default "/bin/bash"    if BR2_SYSTEM_BIN_SH_BASH
>  	default "/bin/dash"    if BR2_SYSTEM_BIN_SH_DASH
>  	default "/bin/zsh"     if BR2_SYSTEM_BIN_SH_ZSH

If you contend that /bin/sh being an absolute symlink is an issue, then
surely the other shells should be treated the same, i.e. they should be
madde relative symlinks.

All that matters in the end is that the symlink is correct *on the
target".  I'm not sure this change is interesting without a good reason;
and I don't think you 10.192.168.1gave a good-enough reason; saying "the
symlink is different than what busybox installs" is not a valid reason
IMHO.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'