[Buildroot] [PATCH v2 2/2] arch: tidy up binary formats config
Guido Martínez
guido at vanguardiasur.com.ar
Wed Jun 3 21:27:53 UTC 2015
On Wed, Jun 03, 2015 at 10:48:43PM +0200, Arnout Vandecappelle wrote:
> On 06/03/15 16:12, Guido Martínez wrote:
> > @@ -272,13 +276,13 @@ config BR2_BINFMT_SUPPORTS_SHARED
> > # Set up target binary format
> > choice
> > prompt "Target Binary Format"
> > - default BR2_BINFMT_ELF if !(BR2_bfin || BR2_m68k)
> > - default BR2_BINFMT_FDPIC if BR2_bfin
> > - default BR2_BINFMT_FLAT if BR2_m68k
> > + default BR2_BINFMT_ELF if BR2_USE_MMU
> > + default BR2_BINFMT_FDPIC if BR2_ARCH_HAS_FDPIC_SUPPORT
> > + default BR2_BINFMT_FLAT if !BR2_USE_MMU
>
> I think this should either be without condition at all, or with a condition
> that matches the previous ones, i.e. if !BR2_USE_MMU && !BR2_ARCH_HAS_FDPIC_SUPPORT.
Ugh, right, either fully use the short circuiting or not at all. I'd say
we use no conditions on FLAT.
> Also we normally don't do any vertical alignment at all, so just put a single
> space instead of tabs.
OK, agreed.
Would it be better for me to resend or is this simple enough to be fixed
up when commiting?
Thanks!
--
Guido Martínez, VanguardiaSur
www.vanguardiasur.com.ar
More information about the buildroot
mailing list