[Buildroot] [RFC 1/2] Makefile: add target-genimage

[Danomi Manchego]

Vivien,

On Mon, Feb 16, 2015 at 11:41 AM, Vivien Didelot
<vivien.didelot at savoirfairelinux.com> wrote:
> Hi Danomi,
>
>> A couple nitpicks ...
>
> [...]
>
>> > The rational behind adding this to Buildroot is that genimage
>> > requires
>>
>> spelling: "rationale".
>
> Thanks.
>
> [...]
>
>> > --- a/Makefile
>> > +++ b/Makefile
>> > @@ -434,7 +434,7 @@ world: target-post-image
>> >
>> >  .PHONY: all world toolchain dirs clean distclean source
>> >  outputmakefile \
>> >         legal-info legal-info-prepare legal-info-clean printvars \
>> > -       target-finalize target-post-image \
>> > +       target-finalize target-genimage target-post-image \
>> >         $(TARGETS) $(TARGETS_ROOTFS) \
>> >         $(TARGETS_DIRCLEAN) $(TARGETS_SOURCE) $(TARGETS_LEGAL_INFO)
>> >         \
>> >         $(BUILD_DIR) $(STAGING_DIR) $(TARGET_DIR) \
>> > @@ -621,7 +621,20 @@ endif
>> >                 $(call MESSAGE,"Executing post-build script $(s)");
>> >                 \
>> >                 $(EXTRA_ENV) $(s) $(TARGET_DIR) $(call
>> >                 qstrip,$(BR2_ROOTFS_POST_SCRIPT_ARGS))$(sep))
>> >
>> > -target-post-image: $(TARGETS_ROOTFS) target-finalize
>> > +target-genimage: $(TARGETS_ROOTFS) target-finalize
>> > +       @$(foreach cfg, $(call qstrip,$(BR2_ROOTFS_GENIMAGE_CFG)),
>> > \
>> > +       $(call MESSAGE,"Executing genimage with config $(cfg)"); \
>> > +         T=$$(mktemp -d $(BUILD_DIR)/.genimage.XXXXXXXXXX); \
>> > +         mkdir -p $$T/{root,tmp}; \
>> > +         $(EXTRA_ENV) output/host/usr/bin/genimage \
>> > +         --rootpath $$T/root \
>> > +         --tmppath $$T/tmp \
>> > +         --inputpath output/images/ \
>> > +         --outputpath output/images/ \
>> > +         --config $(cfg); \
>> > +         rm -rf $$T$(sep))
>>
>> I don't think the final $(sep) is needed, since this the last line of
>> a makefile target, as opposed to, say. a template.
>
> Are you sure? I'm not sure either but I tried to follow the other foreach
> statements.

Ah, so sorry, I missed the fact that it was a foreach.  Comment retracted!


> Thanks for the nitpicks. Other than that, an feedback on the overall RFC?

Sorry, I haven't actually tried it.

Danomi -


> Regards,
> Vivien