[Buildroot] [PATCH 1/2] package/eigen: install .pc file
Yann E. MORIN
yann.morin.1998 at free.fr
Mon Dec 28 21:13:12 UTC 2015
Thomas, All,
On 2015-12-28 22:05 +0100, Thomas Petazzoni spake thusly:
> Dear Yann E. MORIN,
>
> On Mon, 28 Dec 2015 20:08:54 +0100, Yann E. MORIN wrote:
> > Other packages will look for eigen3.pc to detect the presence of eigen3.
> >
> > eigen3.pc is usually installed by eigen's cmake buildsystem, but we do a
> > manual install to not depend on host-cmake just to install header files.
> > But in doing so, we forgot to install the .pc file.
> >
> > Manually sed the source .pc.in to generate the final .pc file.
> >
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> > ---
> > package/eigen/eigen.mk | 9 +++++++++
> > 1 file changed, 9 insertions(+)
>
> Applied, thanks.
:-)
> Since I forgot to fix it in the commit, I did a
> follow-up commit to fix the indentation. You used a mix of tabs and
> spaces in a not very consistent way.
Well, it was not really 'inconsistent' since I did it on purpose:
- the sed's -e expression were all aligned (with tabstop=8)
- the install's source and destination were aligned (with tabstop=8)
But OK, your fix provides another kind of 'consistency' ;-)
Thanks! :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list