[Buildroot] [PATCH 13/51] samba: use <pkg>_INSTALL_INIT_SYSV mechanism

Baruch Siach baruch at tkos.co.il
Mon Nov 24 05:27:33 UTC 2014


Hi Thomas,

On Mon, Nov 24, 2014 at 06:49:22AM +0200, Baruch Siach wrote:
> On Sun, Nov 23, 2014 at 09:38:45PM +0100, Thomas Petazzoni wrote:
> > +define SAMBA_INSTALL_INIT_SYSV
> > +	# install start/stop script
> > +	@if [ ! -f $(TARGET_DIR)/etc/init.d/S91smb ]; then \
> > +		$(INSTALL) -m 0755 -D package/samba/S91smb $(TARGET_DIR)/etc/init.d/S91smb; \
> > +	fi
> > +endef
> 
> Why not install the init script unconditionally like you did in vsftpd?

The same comment goes for the input-event-daemon, netatalk, and gpsd patches 
in this series.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -



More information about the buildroot mailing list