[Buildroot] [PATCH v3 5/5] package: linux-fusion: use install instead of cp
Guido Martínez
guido at vanguardiasur.com.ar
Tue Nov 18 17:17:09 UTC 2014
Hi Arnout, all
On Mon, Nov 17, 2014 at 11:06:05PM +0100, Arnout Vandecappelle wrote:
> On 17/11/14 18:19, Guido Martínez wrote:
> > in order to not depend on the previous permissions of the file
> >
> > Signed-off-by: Guido Martínez <guido at vanguardiasur.com.ar>
>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
>
> There are a few more suspicious cp instances:
>
> board/boundarydevices/nitrogen6x/post-build.sh
> boot/grub/grub.mk
> fs/iso9660/iso9660.mk
I'll take a look at these, thanks.
> Also, it would be good to document somewhere (e.g. in the intro mail) why the
> rsync in the toolchain is OK. Or even better, replace it even though it's not
> really necessary - it just feels more consistent and safe.
Yes, this sounds good. Maybe use --chmod on the toolchain and add a
comment there? This way we should be covered in the future if someone
uses 'rsync -a' from there.
Cheers!
--
Guido Martínez, VanguardiaSur
www.vanguardiasur.com.ar
More information about the buildroot
mailing list