[Buildroot] [PATCH 2/2] package/nodejs: remove config options --without-ssl2 and --without-ssl3

Fabio Porcedda fabio.porcedda at gmail.com
Mon Nov 17 17:38:50 UTC 2014


On Mon, Nov 17, 2014 at 12:41 PM, Jörg Krause <jkrause at posteo.de> wrote:
> The config options --without-ssl2 and --without-ssl3 are intended to be used if
> nodejs is build with the bundled OpenSSL library for excluding the SSL2 and
> SSL3 features.
>
> Both options are actual only evaluated if --without-ssl is not set:
>
> $ cat configure | grep configure_openssl -n -A 13
> 619:def configure_openssl(o):
> 620-  o['variables']['node_use_openssl'] = b(not options.without_ssl)
> 621-  o['variables']['node_shared_openssl'] = b(options.shared_openssl)
> 622-  o['variables']['openssl_no_asm'] = (
> 623-    1 if options.openssl_no_asm else 0)
> 624-
> 625-  if options.without_ssl:
> 626-    return
> 627-
> 628-  if options.ssl2:
> 629-    o['defines'] += ['OPENSSL_NO_SSL2=1']
> 630-
> 631-  if options.ssl3:
> 632-    o['defines'] += ['OPENSSL_NO_SSL3=1']
>
> This patch reverts commit e712638b4adc6e18b3ce99ab37b94530e9aa786f which does
> not help to fix the build errors, eg.:
> http://autobuild.buildroot.net/results/0bf/0bf17bf710db051d491123482c90f2f72810804b/
>
> Signed-off-by: Jörg Krause <jkrause at posteo.de>

Tested-by: Fabio Porcedda <fabio.porcedda at gmail.com>
Acked-by: Fabio Porcedda <fabio.porcedda at gmail.com>

My fault for sending that patch, i was sure to have tested it well.

Thanks
-- 
Fabio Porcedda



More information about the buildroot mailing list