[Buildroot] [PATCH] system: move system.mk recipes inside the "target-finalize" rule
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Thu Jun 12 08:23:39 UTC 2014
Dear Fabio Porcedda,
On Thu, 12 Jun 2014 10:05:41 +0200, Fabio Porcedda wrote:
> > I think one of the concern with the hook thing was that the hooks would
> > be spread all over the Buildroot tree. To mitigate this concern, maybe
> > we could have a naming convention for those hooks that they should all
> > start with TARGET_FINALIZE_<something>, like
> > TARGET_FINALIZE_PURGE_LOCALES ?
>
> Ok fine, i like it, maybe using TARGET_FINALIZE_HOOK_PURGE_LOCALES is
> too verbose?
If anything, the "HOOK" should be at the end. Not sure it's needed
though if we have all variables prefixed by TARGET_FINALIZE_<something>.
That being said, now that I can think of it, we can anyway always grep
all the hooks by grepping for "TARGET_FINALIZE_HOOKS", which will
return all files doing:
TARGET_FINALIZE_HOOKS += <something>
So in the end, the name of make function being registered doesn't
matter much, but still for consistency, I think it's good to have a
common prefix for all of them.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list