[Buildroot] [PATCH 4 of 6] uclibc: rename SETUP_DOT_CONFIG to FIXUP_DOT_CONFIG

Arnout Vandecappelle arnout at mind.be
Mon Jul 14 16:44:01 UTC 2014


On 14/07/14 16:43, Thomas De Schampheleire wrote:
> On Mon, Jul 14, 2014 at 4:39 PM, Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
>> Thomas², All,
>>
>> On 2014-07-14 16:33 +0200, Thomas Petazzoni spake thusly:
>>> On Mon, 14 Jul 2014 13:50:28 +0200, Thomas De Schampheleire wrote:
>>>
>>>> -define UCLIBC_SETUP_DOT_CONFIG
>>>> +define UCLIBC_FIXUP_DOT_CONFIG
>>>>     $(INSTALL) -m 0644 $(UCLIBC_CONFIG_FILE) $(@D)/.config
>>>
>>> This this variable is actually copying the configuration file, I
>>> believe the current name of the variable is more correct than the one
>>> you propose to use, no?
>>
>> Thomas did the change, because in patch 5/6 it no longer does the copy,
>> it only does the fixup.
>>
>> This should probably have been explained in the commit log that the
>> change was needed by a future patch.
> 
> Ok, I see. I split off the change to a separate patch for clarity, but
> indeed at this moment it is not yet fully accurate. I can fold this
> patch with the 5th patch, or otherwise update the commit msg as Yann
> proposed, what do you prefer?

 I'd fold it.

 Regards,
 Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F



More information about the buildroot mailing list