[Buildroot] [PATCH 1/2] infra: improve dependency check in virtual packages.
Thomas De Schampheleire
patrickdepinguin at gmail.com
Mon Feb 24 21:18:31 UTC 2014
"Yann E. MORIN" <yann.morin.1998 at free.fr> schreef:
...
>
>I don't know about you folks, but I'm beginning to see a pattern here...
>
>If all of our BR2_PACKAGE_HAS_FOOBAR options would match the corresponding
>FOOBAR_DEPENDENCIES, then we could use something like (absolutely untested,
>only pure random thoughts):
>
> $(eval $(call virtual-package,FooBar))
>
>whith 'virtual-package' something like:
>
> define virtual-package
> ifeq ($(BR2_PACKAGE_HAS_$(call upper,$(1))),y)
> ifeq ($($(call upper,$(1))_DEPENDENCIES),)
> $(error No $(1) implementation selected. Configuration error.)
> endif
> endif
> endef
>
>But then we would need:
> s/BR2_PACKAGE_HAS_OPENGL_EGL/BR2_PACKAGE_HAS_LIBEGL/
> s/BR2_PACKAGE_HAS_OPENGL_GLES/BR2_PACKAGE_HAS_LIBGLES/
> s/BR2_PACKAGE_HAS_OPENMAX/BR2_PACKAGE_HAS_LIBOPENMAX/
> s/BR2_PACKAGE_HAS_OPENVG/BR2_PACKAGE_HAS_LIBOPENVG/
>
>Lua interpreter and PowerVR already match this.
In the past I complained about the version of virtual packages (like toolchain) being 'undefined'. The idea came up to set it as 'virtual' instead.
I believe at that time, Thomas also said that renaming the libgl symbols should be fine...
Best regards,
Thomas
More information about the buildroot
mailing list