[Buildroot] [PATCH 2/2] pkg-stats: fix proper identification of package infrastructure
Thomas De Schampheleire
patrickdepinguin at gmail.com
Wed Sep 11 09:53:30 UTC 2013
Hi,
On Wed, Sep 11, 2013 at 11:12 AM, Jerzy Grzegorek
<jerzy.grzegorek at trzebnica.net> wrote:
> Typically each package invokes the macro which generates the Makefile code, in the way
> like this: e.g. $(eval $(generic-package)) or $(eval $(autotools-package)) ,
> but a few packages have to invoke this macro in other way:
> $(eval $(call generic-package)) e.g. dhcpcd.mk
> $(eval $(call autotools-package)) e.g. wireshark.mk .
I rather think that the 'call' is an accident. Arnout removed the need
for the extra $(call) in July 2012, with commit
e1502ebc0c92763896c53d405ee9c7c7a1a33e24, and both dhcpcd and
wireshark were added after that time. So I think this has been missed
during code review.
A quick search shows only three packages with a remaining $(eval
$(call)) construct: dhcpcd, wireshark, jquery-keyboard.
So I'd rather fix those packages...
Best regards,
Thomas
More information about the buildroot
mailing list