[Buildroot] SVN process started at make
Peter Korsgaard
jacmet at uclibc.org
Wed Sep 4 09:15:27 UTC 2013
>>>>> "Ruud" == Ruud Commandeur <RCommandeur at clb.nl> writes:
Ruud> Dear Thomas,
Ruud> Well, I did take a quick look at this file, but could have seen this
Ruud> myself indeed :-)
Ruud> So it runs an "svn info" and "svn status". This last command can take
Ruud> quite some time for a large repository, so this explains the delay.
Ok, I'm afraid there's not much to do about svn being crap :/
How come you are only seeing this now? We've been calling
setlocalversion since 2010. Did you recently upgrade your svn version?
Looking at the kernel history (where setlocalversion comes from), I see
a commit from Mike Frysinger where the svn status step is skipped as it
was deemed too slow, so perhaps we should just resync our
setlocalversion script with the kernel:
Author: Mike Frysinger <vapier.adi at gmail.com>
Date: Thu Feb 5 16:13:32 2009 +0800
kbuild,setlocalversion: shorten the make time when using svn
Don't bother doing `svn st` as it takes a retarded amount of time when
the source is cold
Signed-off-by: Mike Frysinger <vapier.adi at gmail.com>
Signed-off-by: Bryan Wu <cooloney at kernel.org>
Signed-off-by: Sam Ravnborg <sam at ravnborg.org>
diff --git a/scripts/setlocalversion b/scripts/setlocalversion
index f6946cf..f1c4b35 100755
--- a/scripts/setlocalversion
+++ b/scripts/setlocalversion
@@ -58,14 +58,7 @@ fi
# Check for svn and a svn repo.
if rev=`svn info 2>/dev/null | grep '^Last Changed Rev'`; then
rev=`echo $rev | awk '{print $NF}'`
- changes=`svn status 2>/dev/null | grep '^[AMD]' | wc -l`
-
- # Are there uncommitted changes?
- if [ $changes != 0 ]; then
- printf -- '-svn%s%s' "$rev" -dirty
- else
- printf -- '-svn%s' "$rev"
- fi
+ printf -- '-svn%s' "$rev"
# All done with svn
exit
I'll do that now.
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list