[Buildroot] [PATCHv3 10/20] toolchain: fix the helpers.mk comment

Thomas De Schampheleire patrickdepinguin at gmail.com
Wed Oct 9 13:58:55 UTC 2013


On Tue, Oct 8, 2013 at 8:17 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> This commit fixes various typos and mistakes in the comment at the top
> of the helpers.mk file:
>
>  * usefull -> useful
>
>  * The optional stripping of libraries no longer exists, so there's no
>    reason to mention it.
>
>  * Indicate that the copy_toolchain_lib_root function is also used by
>    the glibc package, not only by the external toolchain logic.
>
>  * Separate more clearly the top comment introducing the entire file,
>    from the comment introducing the first function.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> ---
>  toolchain/helpers.mk | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk
> index 37f2cf9..d9051ae 100644
> --- a/toolchain/helpers.mk
> +++ b/toolchain/helpers.mk
> @@ -1,9 +1,11 @@
> -# This Makefile fragment declares helper functions, usefull to handle
> +# This Makefile fragment declares helper functions, useful to handle
>  # non- buildroot-built toolchains, eg. purely external toolchains.
> -#
> -# Copy a toolchain library and its symbolic links from the sysroot
> -# directory to the target directory. Also optionaly strips the
> -# library.
> +
> +# The copy_toolchain_lib_root function copies a toolchain library and
> +# its symbolic links from the sysroot directory to the target
> +# directory. Note that this function is used both the external

used for

> +# toolchain logic, and the glibc package, so care must be taken when

I think the comma before 'and the' is not needed.

> +# changing this function.
>  #
>  # Most toolchains (CodeSourcery ones) have their libraries either in
>  # /lib or /usr/lib relative to their ARCH_SYSROOT_DIR, so we search
> --


Best regards,
Thomas



More information about the buildroot mailing list