[Buildroot] [PATCH] libcap-ng: doesn't build on AVR32, requires TLS support

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

 Thomas> Dear Peter Korsgaard,
 Thomas> On Sun, 06 Oct 2013 20:44:30 +0200, Peter Korsgaard wrote:

 Thomas> diff --git a/package/libcap-ng/Config.in b/package/libcap-ng/Config.in
 Thomas> index d1663cd..b799dc9 100644
 Thomas> --- a/package/libcap-ng/Config.in
 Thomas> +++ b/package/libcap-ng/Config.in
 Thomas> @@ -1,5 +1,7 @@
 Thomas> config BR2_PACKAGE_LIBCAP_NG
 Thomas> bool "libcap-ng"
 Thomas> +	# tls support, needed by libcap-ng, not available on avr32
 Thomas> +	depends on !BR2_avr32
 >> 
 >> Shouldn't it then depend on BR2_GCC_ENABLE_TLS (and the avr32 toolchain
 >> not select it)?

 Thomas> It wouldn't work with external toolchains, which is the reason why I
 Thomas> excluded the AVR32 architecture rather than using a BR2_GCC_ENABLE_TLS
 Thomas> condition.

Ok, but from your comment I believe it should also depend on
BR2_GCC_ENABLE_TLS (E.G. it would break on other archs if you disable
TLS support)?

If we start having other packages needing TLS, then we should perhaps
provide the option for external toolchains as well, similar to how we do
for the other toolchain settings.

-- 
Bye, Peter Korsgaard