[Buildroot] [PATCH v7 01/10] libglib2: Bump libglib2 to 2.36.1

[Thomas Petazzoni]

Dear Yann E. MORIN,

On Wed, 22 May 2013 19:30:35 +0200, Yann E. MORIN wrote:

> > Case 1 is correct.  I was trying to make the patch bisect-able.  It's
> > possible that glibmm and glib-networking would fail to build if the
> > version is not consistent.
> 
> Thomas, that was me pointing out that bumping glib2, glibmm and
> glib-networking separately might be an error, and IIRC Spenser confirmed
> that with a test build (discussed on IRC some days ago).

Ok, thanks.

> Spenser, to avoid confusion in the future:
>   - add the relevant commenter as Cc: in the commit log,
>   - and add a little history to your patch commit log, like:
> 
>     blabla: do the foo
> 
>     Some explanations
>     possibly on
>     multiple lines
> 
>     Signed-off-by: you
>     Cc: someone
>     Cc: someone else
>     ---
>     v2 -> v3:
>       - fix this and that (someone else)
>     v1 -> v2:
>       - tweak this and that (someone)
> 
> So the reviewer know what has changed when you resend your patch(es).

Indeed. In this specific case, I believe a comment could be part of the
commit log itself, because it can be useful to preserve in the Git
history why the bump was made as a single commit.

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com