[Buildroot] [PATCH 3/3] rpi-fw: New package

[Yann E. MORIN]

Maxime, Thomas, All,

On Saturday 05 January 2013 Thomas Petazzoni wrote:
> Dear Yann E. MORIN,
> 
> On Sat, 5 Jan 2013 16:36:51 +0100, Yann E. MORIN wrote:
> 
> > > +++ b/package/rpi-fw/Config.in
> > > @@ -0,0 +1,9 @@
> > > +config BR2_PACKAGE_RPI_FW
> > > +	bool "RaspberryPi Firmware"
> > 
> > Today, this package is only used fior the RPI. But that GPU is not specific
> > to the RPI, so what about calling that package "VideoCore bootloader" ?
> 
> I am quite sure the start.elf code is Rasberry Pi specific, so I don't
> think this package is just a "VideoCore bootloader".

Right.

> > > +++ b/package/rpi-fw/cmdline.txt
> > > @@ -0,0 +1 @@
> > > +dwc_otg.fiq_fix_enable=1 sdhci-bcm2708.sync_after_dma=0 dwc_otg.lpm_enable=0 console=tty1 root=/dev/mmcblk0p2 rootfstype=ext4 rootwait
> > 
> > This is typically a reason why I'd like to have a generic way to expressing
> > the different filesystems tht form a sinlge firmware. Here, my root partition
> > is *not* mmcblk0p2, it's p3. And the rootfstype is *not* ext4, it's ext2.
> > 
> > But, I guess we'll have to live with that commandline for now... :-/
> > 
> > Maybe you could just omit the root settings (or replace them with place-
> > holders: root=/dev/XXXX rootfstype=XXXX). Of course, that will depend on
> > the maintainer's opinion. ;-)
> 
> I would like to see a comment added in this file, which mentions this
> is only a sample command line, and we recommend to override it on a
> per-project basis using a post-build script.

I am not sure the bootloader knows how to parse comments in this file.
Instead of installing it as 'cmdline.txt', what about installing it as
'cmdline-sample.txt' with the comment?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'