[Buildroot] [PATCH] getty: add the ability to pass options to getty

Thomas De Schampheleire patrickdepinguin+buildroot at gmail.com
Thu Aug 22 11:01:49 UTC 2013


Hi Assaf,

On Thu, Aug 22, 2013 at 9:28 AM, Assaf Inbal <shmuelzon at gmail.com> wrote:
> Hey,
>
>>  Don't copy the incorrect coding style :-) Use = instead of := and put
>> spaces around it.
>
>
> Just out of curiosity, why would you rather I use =? Is it because that
> macro won't always be evaluated, or is there something else I'm missing?

Technically, in this case, both := and = are fine, and both produce
the same result because the right-hand side is fixed and does not
reference any other make variable.
The more unusual := is thus not really needed, and therefore it has
become buildroot policy to use the simple = in all cases, with spaces
as delimiter. This is also visually the most attractive.

>
> BTW - Would you like me to submit an updated patch?

Yes please. Review the comments provided and send an updated patch
marked as 'PATCH v2'.

Best regards,
Thomas



More information about the buildroot mailing list