[Buildroot] [PATCH] toolchain: add support for glibc

[Arnout Vandecappelle]

On 18/08/13 19:36, Thomas Petazzoni wrote:
> The support for eglibc 2.17 was added to the internal toolchain
> backend for 2013.08. This commit now adds glibc 2.18 support to the
> internal toolchain backend. The building procedure is very similar to
> the one of eglibc, with a few differences, but the two are kept
> separate for now.

  I'm not sure if that's a good idea... Will merging them later be easier?

[snip]
> +define GLIBC_CONFIGURE_CMDS
> +	mkdir -p $(@D)/build
> +	# Do the configuration
> +	(cd $(@D)/build; \
> +		$(TARGET_CONFIGURE_OPTS) \
> +		CFLAGS="-O2 $(GLIBC_EXTRA_CFLAGS)" CPPFLAGS="" \

  The -O2 was required for eglibc. Why do we have it here as well?

[snip]
> +ifeq ($(BR2_PACKAGE_GDB_SERVER),y)
> +GLIBC_LIBS_LIB += libthread_db.so
> +endif

  Shouldn't this lib be installed as well for a gdb without gdbserver? 
I.e., shouldn't the condition be ifeq ($(BR2_PACKAGE_GDB),y)?

[snip]

  Regards,
  Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F