[Buildroot] [PATCH] lua: remove shared library feature

François Perrad francois.perrad at gadz.org
Thu Aug 15 21:51:19 UTC 2013


2013/8/15 Thomas Petazzoni <thomas.petazzoni at free-electrons.com>:
> Dear François Perrad,
>
> On Thu, 15 Aug 2013 18:56:48 +0200, François Perrad wrote:
>> 2013/8/14 Thomas Petazzoni <thomas.petazzoni at free-electrons.com>:
>> > François, Gustavo,
>> >
>> > Can you look at the below patch and tell me what you think?
>> >
>>
>> Seems obsolete (BR2_PACKAGE_LUA_SHARED_LIBRARY was removed).
>
> The option was removed because we now always build a shared library.
> But the idea of the patch we're discussing was to remove the
> possibility of building a shared library for Lua since this isn't
> supported upstream, and we try to avoid having "feature" patches in
> Buildroot.
>
> For the moment, we still have
> package/lua/lua-02-shared-libs-for-lua.patch and
> package/lua/lua-03-shared-libs-for-luac.patch to support building a
> shared library for Lua.
>

Initially, these two patches were merged, and I did the split (see
http://git.buildroot.net/buildroot/commit/package/lua?h=next&id=2c7e9c50e9bef1c494ef90411a466ad320846b96).

I did this because in my point of view :
- lua-03-shared-libs-for-luac.patch is too invasive and not really
useful because the static version of luac is enough.
- lua-02-shared-libs-for-lua.patch is mandatory for using native
extensions, like LuaFileSystem, LuaSocket, ...

Francois

Note : lua-03-shared-libs-for-luac.patch could be removed without any
other change.

> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com



More information about the buildroot mailing list