[Buildroot] [PATCH] libsecret: New package

[Markos Chandras]

On 15 August 2013 11:41, Gustavo Zacarias <gustavo at zacarias.com.ar> wrote:
> On 08/15/2013 07:31 AM, Markos Chandras wrote:
>
>> +config BR2_PACKAGE_LIBSECRET
>> +     bool "libsecret"
>> +     select BR2_PACKAGE_LIBGLIB2
>> +     help
>> +       libsecret is a library for storing and retrieving passwords and other
>> +       secrets. It communicates with the "Secret Service" using DBus.
>> +       gnome-keyring and ksecretservice are both implementations of a Secret
>> +       Service.
>> +
>> +       https://wiki.gnome.org/Libsecret
>
> You forgot to inherit LIBGLIB2 depends (WCHAR, THREADS) and add a
> comment on why it's unavailable when both aren't available.
> Other than that it looks good in principle (untested).
> Regards.

Hi Gustavo,

Thanks for the review.

Would it be better to replace 'select' with 'depend' to avoid
implicitly enabling these toolchain components?

-- 
Regards,
Markos Chandras