[Buildroot] [PATCH] Add lcdproc config options, for driver selection

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Apr 11 10:17:41 UTC 2012


Hello Simon,

Le Wed, 11 Apr 2012 11:02:48 +0100,
spdawson at gmail.com a écrit :

> From: Simon Dawson <spdawson at gmail.com>
> 
> Signed-off-by: Simon Dawson <spdawson at gmail.com>
> ---
>  package/lcdproc/Config.in  |  246 ++++++++++++++++++++++++++++++++++++++++++++
>  package/lcdproc/lcdproc.mk |  151 +++++++++++++++++++++++++++-
>  2 files changed, 396 insertions(+), 1 deletions(-)

Thanks for this patch. I am wondering whether we should have such a
long list of drivers as a menu, or whether we should just provide an
option to give a comma-separated list of drivers. Something like the
following choice:

 [ ] Build all drivers
 [ ] Build custom list of drivers

When the second choice is enabled, then it shows:

 () List of drivers to build

But I don't feel really strongly about this, so please wait for
comments from other Buildroot developers before working on such change.

> +LCDPROC_CONF_OPT = --enable-drivers=$(shell echo $(LCDPROC_DRIVERS) | sed -e 's/ /,/g')

This can be done in pure make:

LCDPROC_CONF_OPT = --enable-drivers=$(subst $(space),$(comma),$(LCDPROC_DRIVERS))

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com



More information about the buildroot mailing list