[Buildroot] [PATCH v2] rsh-redone: new package for rsh/rlogin clients
Mike Frysinger
vapier at gentoo.org
Tue Dec 7 20:54:57 UTC 2010
On Tuesday, December 07, 2010 06:07:26 Peter Korsgaard wrote:
> Mike> +# requires PAM
> Mike> +#config BR2_PACKAGE_RSH_REDONE_RSHD
> Mike> +# bool "rshd"
> Mike> +# depends on BR2_PACKAGE_RSH_REDONE
>
> How useful is this without the server part?
i use rshd from inetutils. ive never tested rshd from this since it requires
pam (as already documented). someone else can if they care.
> Mike> +
> Mike> +define RSH_REDONE_INSTALL_TARGET_CMDS
> Mike> + if [ -n "$(rsh-redone-bin-y)$(rsh-redone-sbin-y)" ] ; then \
> Mike> + $(RSH_REDONE_BUILD_CMDS) DESTDIR=$(TARGET_DIR) \
> Mike> + $(if $(rsh-redone-bin-y),install-bin) \
> Mike> + $(if $(rsh-redone-sbin-y),install-sbin); \
> Mike> + fi
> Mike> +endef
>
> Does this do anything else than just copying the binaries? If not, it
> might be simpler to just do a
>
> for i in $(rsh-redone-bin-y); do $(INSTALL) -m 755 -D $$i
> $(TARGET_DIR)/usr/bin/$$i; done for i in $(rsh-redone-sbin-y); do
> $(INSTALL) -m 755 -D $$i $(TARGET_DIR)/usr/sbin/$$i; done
i prefer to let the package build system do these simple steps to avoid
worrying about changes in between version bumps. this proposal for examples
misses set*id on the binaries, and i'm not entirely sure it is more simple.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.buildroot.org/pipermail/buildroot/attachments/20101207/032f0e7e/attachment-0001.asc>
More information about the buildroot
mailing list